Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement meilisearch search, import translations #378

Merged
merged 10 commits into from
Sep 21, 2023
Merged

feat: implement meilisearch search, import translations #378

merged 10 commits into from
Sep 21, 2023

Conversation

pyphilia
Copy link
Contributor

close #376

@pyphilia pyphilia self-assigned this Sep 13, 2023
@pyphilia pyphilia requested a review from spaenleh September 19, 2023 15:15
@pyphilia pyphilia marked this pull request as ready for review September 20, 2023 11:11
spaenleh
spaenleh requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📖 🌟 Amazing work ! Really like it !

I have left a few comments, lets move this forward !

cypress/e2e/allCollections/allCollections.cy.ts Outdated Show resolved Hide resolved
src/components/collection/CollectionCard.tsx Outdated Show resolved Hide resolved
src/components/collection/CollectionCard.tsx Show resolved Hide resolved
src/components/filters/FilterHeader.tsx Show resolved Hide resolved
src/components/filters/FilterPopper.tsx Show resolved Hide resolved
src/components/pages/AllCollections.tsx Outdated Show resolved Hide resolved
src/components/search/Search.tsx Outdated Show resolved Hide resolved
src/components/search/SearchResults.tsx Show resolved Hide resolved
src/components/search/SearchResults.tsx Outdated Show resolved Hide resolved
src/components/search/SearchResults.tsx Outdated Show resolved Hide resolved
@spaenleh spaenleh added the feature New feature or request label Sep 21, 2023
@pyphilia pyphilia mentioned this pull request Sep 21, 2023
Open
@pyphilia pyphilia requested a review from spaenleh September 21, 2023 12:14
@pyphilia pyphilia merged commit 151243e into main Sep 21, 2023
@pyphilia pyphilia deleted the 376-meilisearch branch September 21, 2023 13:15
@github-actions github-actions bot mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

Assignees

@pyphilia pyphilia

Labels
feature New feature or request v0.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connect meilisearch endpoint to search bars
2 participants
@pyphilia @spaenleh