feat: save file locally when receiving postFile message #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juancarlosfarah
requested changes
Aug 31, 2020
There was a problem hiding this comment.
Looking good to me! Just some minor changes and some optimisation. Maybe @hasanagh can check before merging. Thanks!
public/app/config/config.js
Outdated
| @@ -84,6 +85,12 @@ const ACTIONS_VERBS = { | |||
| LOGOUT: 'logout', | |||
| }; | |||
|
|
|||
| const buildFilesPath = ({ userId, spaceId, name }) => { | |||
There was a problem hiding this comment.
Shouldn't this be singular buildFilePath?
public/app/utilities.js
Outdated
| /** | ||
| * Ensure directories for given filepath exist | ||
| */ | ||
| function ensureDirectoryExistence(filePath) { |
There was a problem hiding this comment.
Maybe we should use fs-extra instead of creating this function? Probably has some in-built safety.
const fs = require('fs-extra');
fs.ensureDirSync(...);
juancarlosfarah
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables to receive file information from an app, and save the file in the database.