267/display data in classrooms #275
Conversation
|
This PR edit
The edition functionalities are also improved to handle the data.
When editing a classroom, we can remove spaces (and all their related data): |
|
@pyphilia, a small comment on the layout of the list of Actions and Resources itself, I think that the delete icon should be on the right. Also, can we use primary colours for icons? Or maybe a grayish one. These black ones are a bit harsh. |
| // update data | ||
| const now = new Date(); | ||
| classroom.assign({ name, updatedAt: now }).write(); | ||
| classroom.assign({ name, lastUpdatedAt: now }).write(); |
There was a problem hiding this comment.
I believe it should be updatedAt, right? We change it last time from this.
| const logger = require('../logger'); | ||
|
|
||
| // @param deleteSelection : map key-value with space id as key to whether the space data should be deleted |
There was a problem hiding this comment.
Should be in JSDoc comment format.
| name, | ||
| deleteSelection, | ||
| }; | ||
| })(); |
There was a problem hiding this comment.
Do you actually need to call the function with the last (); bit? I don't remember it like that in the other classes.
| <> | ||
| <Typography className={classes.dataTitle}>{t('Spaces')}</Typography> | ||
|
|
||
| {spaces.length > 0 ? ( |
There was a problem hiding this comment.
spaces.length no need for > 0
|
|
||
| // username cannot be null if actions or resources are imported | ||
| if (!username && (appInstanceResources || actions)) { | ||
| toastr.error(ERROR_MESSAGE_HEADER, 'A user need to be specified'); |
There was a problem hiding this comment.
needs. Do we factor out and translate?
| @@ -0,0 +1,55 @@ | |||
| export const isClassroomNameValid = name => { | |||
There was a problem hiding this comment.
We might want to have simple, but specific unit tests for these functions.
src/utils/classroom.js
Outdated
| return name.trim().length; | ||
|
|
||
| // check name is a string | ||
| if (typeof name !== 'string' && !(name instanceof String)) { |
There was a problem hiding this comment.
I would recommend using Lodash. https://lodash.com/docs#isString
close #267