fix: delete space resources with space #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juancarlosfarah
requested changes
Dec 21, 2018
public/electron.js
Outdated
| } | ||
| // resources in the space but not used by other spaces | ||
| const allResourcesSet = new Set(allResources); | ||
| const spaceDisntictResources = new Set([...spaceResources].filter(filePath => !allResourcesSet.has(filePath))); |
hasanagh
force-pushed
the
11/fix-deleting-a-space
branch
from
cf1e1e1 to
5db5a2a
Compare
removed the resources used by the space only close #11
juancarlosfarah
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed the resources used by the space only
close #11