generated from graasp/graasp-repo
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to pure TS package to reduce bundle size #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaenleh
force-pushed
the
test-reduce-bundle
branch
from
April 12, 2023 08:22
54fe43e
to
a54d378
Compare
spaenleh
force-pushed
the
test-reduce-bundle
branch
2 times, most recently
from
April 12, 2023 09:38
ade4df5
to
c3d6d9c
Compare
spaenleh
force-pushed
the
test-reduce-bundle
branch
from
April 12, 2023 09:42
c3d6d9c
to
6194f97
Compare
spaenleh
force-pushed
the
test-reduce-bundle
branch
from
April 12, 2023 11:31
0853a2b
to
39c3268
Compare
spaenleh
force-pushed
the
test-reduce-bundle
branch
from
April 12, 2023 14:18
736ecab
to
466c300
Compare
spaenleh
changed the title
Reduce bundle size
Move to pure TS package to reduce bundle size
Apr 12, 2023
pyphilia
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍽️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
tsc
withtsc-alias
to resolve absolute paths to relative pathsIssues:
The resulting bundle size for builder is currently around 1.2Mb versus 2.17Mb for the current main version.
Before:
After: