Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adapt types to use sdk instead of query-client #74

Merged
merged 4 commits into from
Feb 17, 2023
Merged

fix: adapt types to use sdk instead of query-client #74

merged 4 commits into from
Feb 17, 2023

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Feb 13, 2023 •
edited
Loading

This PR removes the usage of types exported from query-client and instead uses the ones provided by @graasp/sdk/frontend.

Update yarn to 3.4.1

✅ Ready to merge ! Needs to be merged after graasp/graasp-sdk#75 and before graasp/graasp-builder#440

closes #73

@spaenleh spaenleh added bug Something isn't working chore Generic task or chore labels Feb 13, 2023
@spaenleh spaenleh self-assigned this Feb 13, 2023
@spaenleh spaenleh linked an issue Feb 13, 2023 that may be closed by this pull request
Update types #73
Closed
@spaenleh spaenleh marked this pull request as draft February 13, 2023 07:46
@spaenleh
Copy link
Member Author

spaenleh commented Feb 13, 2023 •
edited
Loading

Need to fix tests.

@spaenleh spaenleh marked this pull request as ready for review February 13, 2023 08:28
@spaenleh spaenleh requested a review from swouf February 17, 2023 08:00
pyphilia
pyphilia reviewed Feb 17, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌻

example/src/components/ChatboxWrapper.tsx Show resolved Hide resolved
src/components/Chatbox/Chatbox.tsx Show resolved Hide resolved
@spaenleh spaenleh mentioned this pull request Feb 17, 2023
Closed
@spaenleh spaenleh merged commit d116f28 into main Feb 17, 2023
@spaenleh spaenleh deleted the 73-update-types branch February 17, 2023 08:30
@github-actions github-actions bot mentioned this pull request Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@codeofmochi codeofmochi Awaiting requested review from codeofmochi

@swouf swouf Awaiting requested review from swouf

Assignees

@spaenleh spaenleh

Labels
bug Something isn't working chore Generic task or chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update types
2 participants
@spaenleh @pyphilia