439/add export chat #440
Merged
439/add export chat #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: add log for input text fix: udpate chatbox version test: fixed regex with numbered capture group feat: add export chat button and download chat for admins fix: failing tests fix: currentMember error fix: clearItemChat mock failing build: update deps
Use enums from sdk Move js enums in tests Move a lot of files to TS Uniformise the type of item to ItemRecord
spaenleh
force-pushed
the
439/addExportChat
branch
from
c5f052d to
8ea854b
Compare
spaenleh
commented
Feb 13, 2023
spaenleh
force-pushed
the
439/addExportChat
branch
from
1e3cfea to
5efdd9e
Compare
codeofmochi
approved these changes
Feb 20, 2023
| @@ -85,7 +88,7 @@ const ItemSharingTab = ({ item }: Props): JSX.Element => { | |||
| todo: show only if item is pseudomized | |||
| */} | |||
| {/* // todo: this will change with the refactor */} | |||
| {getItemLoginSchema(item?.extra as any) && ( | |||
| {getItemLoginSchema(item?.extra as { itemLogin?: ItemLogin }) && ( | |||
There was a problem hiding this comment.
Why is the cast still necessary here?
There was a problem hiding this comment.
I am not sur how the itemLogin extra works. We may have to adjust the type to make this cast caduc, for the moment I don't think there is a way of removing it.
There was a problem hiding this comment.
@pyphilia can you help us out here ? Is the itemLogin extra only available on folders ?
pyphilia
approved these changes
Feb 21, 2023
codeofmochi
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the "export chat" and "clear chat" button in the item settings.
A bunch of files were also moved to TS.
Types now come from
@graasp/sdk/frontend.A stub for
/p/item-membershipswas added.closes #439