feat: restrict admin actions to delete

graasp · Apr 29, 2022 · 5cc9c76 · 5cc9c76
1 parent c7c53fc
commit 5cc9c76
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 11 deletions.
diff --git a/src/components/MessageActions.tsx b/src/components/MessageActions.tsx
@@ -21,6 +21,7 @@ import { useEditingContext } from '../context/EditingContext';
 
 type Props = {
   message: ChatMessage;
+  isOwn?: boolean;
   deleteMessageFunction?: (message: PartialChatMessage) => void;
 };
 
@@ -33,7 +34,11 @@ const useStyles = makeStyles(() => ({
   },
 }));
 
-const MessageActions: FC<Props> = ({ message, deleteMessageFunction }) => {
+const MessageActions: FC<Props> = ({
+  message,
+  deleteMessageFunction,
+  isOwn = false,
+}) => {
   const [menuOpen, setMenuOpen] = useState(false);
   const [menuAnchor, setMenuAnchor] = useState<HTMLElement | null>(null);
   const classes = useStyles();
@@ -80,16 +85,21 @@ const MessageActions: FC<Props> = ({ message, deleteMessageFunction }) => {
           horizontal: 'right',
         }}
       >
-        <MenuItem
-          data-cy={editMenuItemCypress}
-          onClick={handleEditMessage}
-          dense
-        >
-          <ListItemIcon className={classes.menu}>
-            <Edit color="primary" />
-          </ListItemIcon>
-          <ListItemText>{t(CHATBOX.EDIT_BUTTON)}</ListItemText>
-        </MenuItem>
+        {
+          // only show the edit button on own messages
+          isOwn && (
+            <MenuItem
+              data-cy={editMenuItemCypress}
+              onClick={handleEditMessage}
+              dense
+            >
+              <ListItemIcon className={classes.menu}>
+                <Edit color="primary" />
+              </ListItemIcon>
+              <ListItemText>{t(CHATBOX.EDIT_BUTTON)}</ListItemText>
+            </MenuItem>
+          )
+        }
         <MenuItem
           data-cy={deleteMenuItemCypress}
           onClick={handleDeleteMessage}

diff --git a/src/components/Messages.tsx b/src/components/Messages.tsx
@@ -111,6 +111,7 @@ const Messages: FC<Props> = ({
                   {(isOwnMessage || isAdmin) && (
                     <MessageActions
                       message={message}
+                      isOwn={isOwnMessage}
                       deleteMessageFunction={deleteMessageFunction}
                     />
                   )}