Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use sentry to catch errors and have a client feedback #800

Merged
merged 6 commits into from
Oct 16, 2023

Conversation

LinaYahya
Copy link
Contributor

@LinaYahya LinaYahya commented Sep 22, 2023

  • use sentry to catch thrown errors with a fallback component.
  • use sentry report dialog to get user feedback.
  • we can integrate sentry with slack referring to the provided steps

closes #542

@LinaYahya LinaYahya marked this pull request as ready for review September 26, 2023 09:07
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, I think it can be improved! Also where are the tests? 👀 (but it can make sense to first review the feature and then write the tests after a first review so no worry).

src/langs/en.json Outdated Show resolved Hide resolved
src/components/Fallback.tsx Outdated Show resolved Hide resolved
src/components/Fallback.tsx Outdated Show resolved Hide resolved
src/components/main/MainMenu.tsx Outdated Show resolved Hide resolved
src/components/main/MainMenu.tsx Outdated Show resolved Hide resolved
src/components/main/MainMenu.tsx Outdated Show resolved Hide resolved
src/components/main/MainMenu.tsx Outdated Show resolved Hide resolved
src/components/main/MainMenu.tsx Outdated Show resolved Hide resolved
@spaenleh
Copy link
Member

@LinaYahya I added some changes to make the fallback responsive and display the menu items like in a list without too much trickery:
Responsive fallback:
Screenshot 2023-10-16 at 11 32 21

Large screen fallback (no visible change):
Screenshot 2023-10-16 at 11 32 02

"Report a bug" and "Tutorials" appear as list items, same as for the elements on top:
Screenshot 2023-10-16 at 11 14 48

@spaenleh spaenleh dismissed pyphilia’s stale review October 16, 2023 10:39

Changed approach, review comments were incorporated in new design

@spaenleh spaenleh merged commit 785beba into main Oct 16, 2023
3 checks passed
@spaenleh spaenleh added the feature New feature or request label Oct 16, 2023
@spaenleh spaenleh deleted the 542-bugs-reporting branch October 16, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request v1.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report a bug button
3 participants