Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: build create app cards #792

Merged
merged 4 commits into from
Sep 25, 2023
Merged

feat: build create app cards #792

merged 4 commits into from
Sep 25, 2023

Conversation

LinaYahya
Copy link
Contributor

@LinaYahya LinaYahya commented Sep 12, 2023 •
edited
Loading

Convert apps to cards instead of having a dropdown menu

image

Add Custom App

image

Closes #792

@LinaYahya LinaYahya marked this pull request as draft September 12, 2023 15:16
@LinaYahya LinaYahya marked this pull request as ready for review September 13, 2023 07:52
@LinaYahya LinaYahya requested a review from pyphilia September 13, 2023 07:57
pyphilia
pyphilia requested changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I've left some comments, let me know if you have questions! 🍇

src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
src/components/main/AppCard.tsx Outdated Show resolved Hide resolved
src/components/main/AppCard.tsx Outdated Show resolved Hide resolved
src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
pyphilia
pyphilia approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only this change and it's good for me!

src/components/item/form/AppForm.tsx Show resolved Hide resolved
@pyphilia pyphilia temporarily deployed to development September 21, 2023 15:20 — with GitHub Actions Inactive
@LinaYahya LinaYahya merged commit cd8e5f7 into main Sep 25, 2023
@github-actions github-actions bot mentioned this pull request Sep 25, 2023
Merged
@spaenleh spaenleh deleted the 569-create-app-cards branch October 4, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

Assignees

@LinaYahya LinaYahya

Labels
v1.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinaYahya @pyphilia