Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: wrapping long item name #786

Merged
merged 2 commits into from
Sep 13, 2023
Merged

style: wrapping long item name #786

merged 2 commits into from
Sep 13, 2023

Conversation

LinaYahya
Copy link
Contributor

@LinaYahya LinaYahya commented Sep 8, 2023 •
edited
Loading

Relates #785

Expected Result

image

@LinaYahya LinaYahya linked an issue Sep 8, 2023 that may be closed by this pull request
UI | item with a long name should be trimmed #785
Closed
@LinaYahya LinaYahya requested a review from pyphilia September 8, 2023 10:05
@LinaYahya LinaYahya self-assigned this Sep 8, 2023
pyphilia
pyphilia requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🐞 I've added some comments, let me know if you have any question.

src/components/item/ItemMain.tsx Outdated Show resolved Hide resolved
src/components/item/ItemMain.tsx Outdated Show resolved Hide resolved
src/components/main/ItemsToolbar.tsx Outdated Show resolved Hide resolved
@LinaYahya LinaYahya requested a review from pyphilia September 11, 2023 11:25
@pyphilia pyphilia temporarily deployed to development September 13, 2023 07:43 — with GitHub Actions Inactive
@pyphilia pyphilia merged commit d0add75 into main Sep 13, 2023
@pyphilia pyphilia deleted the 785-wrapping-item-long-name branch September 13, 2023 07:47
@github-actions github-actions bot mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

Assignees

@LinaYahya LinaYahya

Labels
v1.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI | item with a long name should be trimmed
2 participants
@LinaYahya @pyphilia