feat: simple tour #705
Open
feat: simple tour #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyphilia
requested changes
Jul 19, 2023
| const iconInTextStyle = { | ||
| width: 20, | ||
| height: 20, | ||
| marginBottom: '-4px', |
There was a problem hiding this comment.
Can this be a bit more dynamic?
Comment on lines
+31
to
+32
| content: 'Welcome', | ||
| locale: { skip: 'Skip' }, |
There was a problem hiding this comment.
Translations? If it's a prototype it can be done later.
| 'With this button, you can close the side bar to free some screen space.', | ||
| target: `#${TOUR_NAVIGATION_SIDEBAR_CLOSE_BUTTON_ID}`, | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
Everything in there should have translations?
Comment on lines
+30
to
+31
| // position: 'absolute', | ||
| // bottom: 0, |
| @@ -39,6 +40,8 @@ import ImportH5P from './ImportH5P'; | |||
| import ImportZip from './ImportZip'; | |||
| import ItemTypeTabs from './ItemTypeTabs'; | |||
|
|
|||
| // import TourContext, { TourContextData } from './TourContext'; | |||
| @@ -61,6 +64,7 @@ type Props = { | |||
| const NewItemModal = ({ open, handleClose }: Props): JSX.Element => { | |||
| const { t: translateBuilder } = useBuilderTranslation(); | |||
| const { t: translateCommon } = useCommonTranslation(); | |||
| // const { isTourOpen } = useContext(TourContext) as TourContextData; | |||
| onClose={handleClose} | ||
| maxWidth="md" | ||
| fullWidth | ||
| // disableEnforceFocus={isTourOpen} |
spaenleh
force-pushed
the
main
branch
2 times, most recently
from
0791683 to
b513c2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.