Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add published tab to main menu #695

Merged
merged 5 commits into from
Jul 27, 2023
Merged

feat: add published tab to main menu #695

merged 5 commits into from
Jul 27, 2023

Conversation

codeofmochi
Copy link
Contributor

@codeofmochi codeofmochi commented Jul 5, 2023

This PR adds a "published items" tab to the main menu
Closes #563

image

Todo:

  • Should we display the roots using the library cards?
  • What should happen on click of a collection; should it show the "inside" in builder (current behaviour) or the publication page on library instead?
  • Check what should be the required permissions on the "view published items of member" endpoint
  • Update translations (and query client, other deps, if needed)

For later:

  • The items table has a fixed size, why? I think it should auto-resize given the number of elements in it up to the page's height. Can we use a flex layout for that? To be investigated.
  • Once the above is fixed, add library suggestions (e.g. recent or most liked for instance) below

@codeofmochi codeofmochi self-assigned this Jul 5, 2023
@codeofmochi codeofmochi added the feature New feature or request label Jul 5, 2023
@spaenleh
Copy link
Member

Suggestion: Use the "library" icon for the left tab, to match the itemBadges. The "globe" icon means "public".

@codeofmochi codeofmochi requested review from pyphilia and spaenleh and removed request for pyphilia, morganridel and spaenleh July 24, 2023 08:44
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌐 📚 Looks good to me ! ⭐ See my comments an suggestions.

package.json Outdated Show resolved Hide resolved
src/components/main/ItemsTable.tsx Outdated Show resolved Hide resolved
src/components/main/MainMenu.tsx Outdated Show resolved Hide resolved
@codeofmochi codeofmochi marked this pull request as ready for review July 26, 2023 14:19
@codeofmochi codeofmochi requested a review from spaenleh July 26, 2023 14:58
@codeofmochi
Copy link
Contributor Author

@spaenleh does this close #589 ?

Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, otherwise looks good to me, thank you for integrating the changes for the loadable content ! 🌈 ⏳

package.json Outdated Show resolved Hide resolved
src/components/main/MainMenu.tsx Outdated Show resolved Hide resolved
@spaenleh
Copy link
Member

@spaenleh does this close #589 ?

Yes I think it does ! You can test it, if you see the hand and then the main (left bar and title bar) and only the center table content has the circular loading it means it worked !

@codeofmochi codeofmochi linked an issue Jul 26, 2023 that may be closed by this pull request
@codeofmochi codeofmochi merged commit a187372 into main Jul 27, 2023
@codeofmochi codeofmochi deleted the 563-published-tab branch July 27, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request v1.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move loading indicators Add user's published items in main left menu
2 participants