Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove player button from item header actions #575

Merged
merged 1 commit into from
Feb 28, 2023
Merged

fix: remove player button from item header actions #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cypress/support/viewUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import {
TEXT_EDITOR_CLASS,
buildEditButtonId,
buildFileItemId,
buildPlayerButtonId,
buildSettingsButtonId,
buildShareButtonId,
} from '../../src/config/selectors';
Expand Down Expand Up @@ -53,7 +52,6 @@ export const expectItemHeaderLayout = ({
const header = cy.get(`#${ITEM_HEADER_ID}`);

header.get(`#${buildShareButtonId(id)}`).should('exist');
header.get(`#${buildPlayerButtonId(id)}`).should('exist');

if (
isSettingsEditionAllowedForUser({
Expand Down
2 changes: 0 additions & 2 deletions src/components/item/header/ItemHeaderActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import {
import AnalyticsDashboardButton from '../../common/AnalyticsDashboardButton';
import EditItemCaptionButton from '../../common/EditItemCaptionButton';
import ItemMetadataButton from '../../common/ItemMetadataButton';
import PlayerViewButton from '../../common/PlayerViewButton';
import PublishButton from '../../common/PublishButton';
import ShareButton from '../../common/ShareButton';
import { useCurrentUserContext } from '../../context/CurrentUserContext';
Expand Down Expand Up @@ -76,7 +75,6 @@ const ItemHeaderActions = ({ item }: Props): JSX.Element => {
id={ITEM_CHATBOX_BUTTON_ID}
onClick={onClickChatbox}
/>
<PlayerViewButton itemId={id} />
{canAdmin && <PublishButton itemId={id} />}
{canEdit && <AnalyticsDashboardButton id={id} />}
</>
Expand Down