Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve accessibility for mainmenu and table #555

Merged
merged 1 commit into from
Feb 14, 2023
Merged

feat: improve accessibility for mainmenu and table #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@graasp/query-client": "0.1.3",
"@graasp/sdk": "0.3.0",
"@graasp/translations": "1.3.0",
"@graasp/ui": "0.9.0",
"@graasp/ui": "github:graasp/graasp-ui#226-table-menu-a11y",
"@mui/icons-material": "5.11.0",
"@mui/lab": "5.0.0-alpha.117",
"@mui/material": "5.11.6",
Expand Down
1 change: 1 addition & 0 deletions src/components/main/ItemsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ const ItemsTable: FC<Props> = ({
{
field: 'actions',
cellRenderer: actions ?? ActionComponent,
suppressKeyboardEvent: GraaspTable.suppressKeyboardEventForParentCell,
headerName: translateBuilder(BUILDER.ITEMS_TABLE_ACTIONS_HEADER),
colId: 'actions',
type: 'rightAligned',
Expand Down
24 changes: 12 additions & 12 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2525,17 +2525,18 @@ __metadata:
languageName: node
linkType: hard

"@graasp/ui@npm:0.7.1":
version: 0.7.1
resolution: "@graasp/ui@npm:0.7.1"
"@graasp/ui@github:graasp/graasp-ui#226-table-menu-a11y":
version: 0.10.2
resolution: "@graasp/ui@https://github.com/graasp/graasp-ui.git#commit=a6e8bee0e668e8a7332b6489548cd08c8a354444"
dependencies:
"@graasp/sdk": "github:graasp/graasp-sdk.git"
"@graasp/sdk": 0.2.0
clsx: 1.1.1
http-status-codes: 2.2.0
immutable: 4.1.0
katex: 0.16.0
lodash.truncate: 4.4.2
qs: 6.10.5
quill-emoji: 0.2.0
react-cookie-consent: 7.4.1
react-i18next: 11.17.0
react-quill: 2.0.0-beta.4
Expand All @@ -2559,22 +2560,21 @@ __metadata:
optional: true
ag-grid-react:
optional: true
checksum: b09b2adaa1f72b82c35dc86d2bb9fc578336c9b2858fee18302ed82c79046143ac371ce8415ad01a9385ece40e9a8634a53f9aee67d33b2e3752052b59eac5bb
checksum: dec2af8df6186414fe5b6822dd6dc78e59245143243863afa1edcd84669000bfb2ab85a9dcd151a872d943322686820f00deabe8f4d23506c61e566760701663
languageName: node
linkType: hard

"@graasp/ui@npm:0.9.0":
version: 0.9.0
resolution: "@graasp/ui@npm:0.9.0"
"@graasp/ui@npm:0.7.1":
version: 0.7.1
resolution: "@graasp/ui@npm:0.7.1"
dependencies:
"@graasp/sdk": 0.2.0
"@graasp/sdk": "github:graasp/graasp-sdk.git"
clsx: 1.1.1
http-status-codes: 2.2.0
immutable: 4.1.0
katex: 0.16.0
lodash.truncate: 4.4.2
qs: 6.10.5
quill-emoji: 0.2.0
react-cookie-consent: 7.4.1
react-i18next: 11.17.0
react-quill: 2.0.0-beta.4
Expand All @@ -2598,7 +2598,7 @@ __metadata:
optional: true
ag-grid-react:
optional: true
checksum: 2e2df0cea62e62c189f7c9a69281a67451423b8cb630f282f34a5ca79987805f03e7bea564eb5f70a0037f55d5493f7c53478cd452d8f692aa617fd346c95ab6
checksum: b09b2adaa1f72b82c35dc86d2bb9fc578336c9b2858fee18302ed82c79046143ac371ce8415ad01a9385ece40e9a8634a53f9aee67d33b2e3752052b59eac5bb
languageName: node
linkType: hard

Expand Down Expand Up @@ -10142,7 +10142,7 @@ __metadata:
"@graasp/query-client": 0.1.3
"@graasp/sdk": 0.3.0
"@graasp/translations": 1.3.0
"@graasp/ui": 0.9.0
"@graasp/ui": "github:graasp/graasp-ui#226-table-menu-a11y"
"@graasp/websockets": "github:graasp/graasp-websockets.git"
"@mui/icons-material": 5.11.0
"@mui/lab": 5.0.0-alpha.117
Expand Down