This repository has been archived by the owner on Jan 23, 2025. It is now read-only.
feat: add Resizable item setting #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaenleh
force-pushed
the
500-manual-resizing-setting
branch
from
069f20d to
173334d
Compare
spaenleh
force-pushed
the
500-manual-resizing-setting
branch
from
173334d to
50b6789
Compare
pyphilia
approved these changes
Jan 9, 2023
Comment on lines
+85
to
+88
| if (typeof option === 'string') { | ||
| return option; | ||
| } | ||
| return option.url; |
There was a problem hiding this comment.
According to the types, it can only be a string | RecordOf<App>.
There was a problem hiding this comment.
@pyphilia I can type it explicitly If you prefer
codeofmochi
reviewed
Jan 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the manual resize item setting.
It should also fix #493 by filtering options to the ones containing the search string.
The prettier command was updated to also format TS/TSX files. This generated some noise that was committed under 50b6789.
Needs:
closes #500