Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

344 add h5p #383

Merged
merged 10 commits into from
Aug 17, 2022
Merged

344 add h5p #383

merged 10 commits into from
Aug 17, 2022

Conversation

codeofmochi
Copy link
Contributor

@codeofmochi codeofmochi commented Jun 16, 2022 •
edited
Loading

Close #344

Adds support for H5P import and display in compose

TODO:

  • merge dependencies first, then update package.json with non-branch URLs
  • implement download

@codeofmochi codeofmochi added the feature New feature or request label Jun 16, 2022
@codeofmochi codeofmochi requested review from pyphilia and spaenleh June 16, 2022 10:16
@codeofmochi codeofmochi self-assigned this Jun 16, 2022
spaenleh
spaenleh requested changes Jun 16, 2022
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a comment about some constants that can be factored out maybe ⛹🏻‍♂️

src/utils/uppy.js Outdated Show resolved Hide resolved
pyphilia
pyphilia requested changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

README.md Outdated Show resolved Hide resolved
src/config/constants.js Outdated Show resolved Hide resolved
src/components/main/ImportH5P.js Outdated Show resolved Hide resolved
@codeofmochi codeofmochi force-pushed the 344-add-h5p branch 6 times, most recently from b73f5ae to a9ac7c4 Compare August 16, 2022 13:25
@codeofmochi codeofmochi merged commit ef4d3b7 into master Aug 17, 2022
@codeofmochi codeofmochi deleted the 344-add-h5p branch August 17, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh requested changes

@pyphilia pyphilia pyphilia requested changes

Assignees

@codeofmochi codeofmochi

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add H5P support
3 participants
@codeofmochi @pyphilia @spaenleh