Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add co-editor settings #373

Merged
merged 8 commits into from
Jul 4, 2022
Merged

feat: add co-editor settings #373

merged 8 commits into from
Jul 4, 2022

Conversation

louisewang1
Copy link
Contributor

Add co-editor display setting in publish tab

@louisewang1 louisewang1 requested a review from pyphilia June 6, 2022 15:10
@louisewang1 louisewang1 force-pushed the 366/publishItemRefactor branch from 4963bdd to dd634fb Compare June 6, 2022 15:14
@louisewang1
Copy link
Contributor Author

image

pyphilia
pyphilia requested changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've left some comments :
Could we add trivial tests? Check the setting is displayed, and you can click it and it trigger the correct request.

src/components/item/publish/CoEditorSettings.js Outdated Show resolved Hide resolved
src/components/item/publish/CoEditorSettings.js Outdated Show resolved Hide resolved
src/components/item/publish/CoEditorSettings.js Outdated Show resolved Hide resolved
src/config/constants.js Outdated Show resolved Hide resolved
@louisewang1 louisewang1 force-pushed the 366/publishItemRefactor branch from aa143f6 to 7f033da Compare June 22, 2022 13:48
@louisewang1
Copy link
Contributor Author

louisewang1 commented Jun 22, 2022 •
edited
Loading

checkbox for email notification
image
I have re-requested a review on this PR mainly for the new feature on email notification checkbox and the new mutation for publish. @pyphilia

@louisewang1 louisewang1 requested a review from pyphilia June 22, 2022 14:31
pyphilia
pyphilia requested changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've left some minor comments 🍇

cypress/integration/item/publish/coEditorSettings.spec.js Outdated Show resolved Hide resolved
cypress/integration/item/publish/coEditorSettings.spec.js Outdated Show resolved Hide resolved
cypress/support/server.js Outdated Show resolved Hide resolved
src/components/item/publish/CoEditorSettings.js Outdated Show resolved Hide resolved
src/components/item/publish/CoEditorSettings.js Outdated Show resolved Hide resolved
src/components/item/publish/ItemPublishButton.js Show resolved Hide resolved
src/components/item/publish/ItemPublishButton.js Outdated Show resolved Hide resolved
src/components/item/publish/ItemPublishButton.js Outdated Show resolved Hide resolved
src/components/item/publish/ItemPublishButton.js Outdated Show resolved Hide resolved
cypress/integration/item/publish/coEditorSettings.spec.js Outdated Show resolved Hide resolved
@louisewang1 louisewang1 force-pushed the 366/publishItemRefactor branch from 231f61b to b0015ea Compare June 29, 2022 13:57
@louisewang1 louisewang1 force-pushed the 366/publishItemRefactor branch from b0015ea to 082f77e Compare July 4, 2022 13:56
@louisewang1 louisewang1 merged commit 270a569 into master Jul 4, 2022
@pyphilia pyphilia deleted the 366/publishItemRefactor branch November 23, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louisewang1 @pyphilia