Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use react hook form for document forms #1580

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Conversation

pyphilia
Copy link
Contributor

Split Document form into create and edit.
Finally could remove some dirty code in NewItemModal.

ref #1551

@pyphilia pyphilia requested review from spaenleh and ReidyT November 22, 2024 14:28
@pyphilia pyphilia self-assigned this Nov 22, 2024
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌝

cypress/e2e/item/create/createDocument.cy.ts Outdated Show resolved Hide resolved
@pyphilia pyphilia enabled auto-merge November 26, 2024 12:43
@pyphilia pyphilia added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit bfe4205 Nov 26, 2024
4 checks passed
@spaenleh spaenleh deleted the 1551-document-form branch November 29, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants