Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use react hook form for link create modal #1545

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

pyphilia
Copy link
Contributor

ref #1498

@pyphilia pyphilia requested review from spaenleh and ReidyT October 24, 2024 15:25
@pyphilia pyphilia self-assigned this Oct 24, 2024
@pyphilia pyphilia force-pushed the 1498-link-create-modal branch from eee1b47 to 65d844c Compare October 24, 2024 16:06
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

src/components/item/form/link/LinkForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/link/LinkForm.tsx Outdated Show resolved Hide resolved
@pyphilia pyphilia force-pushed the 1498-link-create-modal branch from 65d844c to dfb2fb9 Compare October 25, 2024 08:04
Copy link

@pyphilia pyphilia requested a review from spaenleh October 25, 2024 08:06
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛴

@pyphilia pyphilia added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 760b77a Oct 25, 2024
4 checks passed
@pyphilia pyphilia deleted the 1498-link-create-modal branch November 4, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants