Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: does not trigger drag on mousedown svg #1396

Merged
merged 1 commit into from
Aug 6, 2024
Merged

fix: does not trigger drag on mousedown svg #1396

merged 1 commit into from
Aug 6, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Aug 5, 2024

Currently there's a small bug happening if you drag and you specifically click on an icon (svg), it will allow you to drag but then it will trigger the multi selection.

This should fix the problem.

@pyphilia pyphilia requested a review from ReidyT August 5, 2024 09:12
@pyphilia pyphilia self-assigned this Aug 5, 2024
Copy link

sonarqubecloud bot commented Aug 5, 2024

Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice fix

@pyphilia pyphilia added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit 8595ccf Aug 6, 2024
4 checks passed
@pyphilia pyphilia deleted the card-svg-drag branch August 6, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants