Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent map to loop #1388

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix: prevent map to loop #1388

merged 1 commit into from
Jul 31, 2024

Conversation

pyphilia
Copy link
Contributor

No description provided.

@pyphilia pyphilia added bug 🪲 Something isn't working priority Give priority to this issue labels Jul 29, 2024
@pyphilia pyphilia self-assigned this Jul 29, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

spaenleh
spaenleh approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, can you quickly explain what was the cause of the issue for the loop ?

GG on finding the cause btw ! 💪

ReidyT
ReidyT approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow good catch ! Yeah, I'm also interested to know why this caused the issue 😆

@pyphilia
Copy link
Contributor Author

Honestly I'm not sure, I corrected it because it was not really correct. I guess this works currently because we don't change language in the same platform, so no need to listen on i18n, but I'm not sure why the map was triggering looping :/

@pyphilia pyphilia added this pull request to the merge queue Jul 31, 2024
@pyphilia pyphilia removed this pull request from the merge queue due to a manual request Jul 31, 2024
@pyphilia pyphilia added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 4ac1f83 Jul 31, 2024
5 checks passed
@graasper graasper mentioned this pull request Jul 29, 2024
Merged
@pyphilia pyphilia deleted the prevent-map-loop branch July 31, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@spaenleh spaenleh spaenleh approved these changes

@LinaYahya LinaYahya Awaiting requested review from LinaYahya

Assignees

@pyphilia pyphilia

Labels
bug 🪲 Something isn't working priority Give priority to this issue v2.34.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pyphilia @spaenleh @ReidyT