Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warning about UNSAFE_componentWillMount using react-helmet-async #1322

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix: warning about UNSAFE_componentWillMount using react-helmet-async #1322

merged 1 commit into from
Jul 5, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Jul 4, 2024

In this PR I fix #1259 by swapping react-helmet for react-helmet-async.

I had to add the HelmetProvider context to the top of the app.

@spaenleh spaenleh self-assigned this Jul 4, 2024
@spaenleh spaenleh added bug 🪲 Something isn't working dependencies chore General chore and removed bug 🪲 Something isn't working labels Jul 4, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh added this pull request to the merge queue Jul 5, 2024
Merged via the queue into main with commit d425527 Jul 5, 2024
4 checks passed
@graasper graasper mentioned this pull request Jul 5, 2024
Merged
@spaenleh spaenleh deleted the 1259-react-helmet-async branch July 15, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@LinaYahya LinaYahya Awaiting requested review from LinaYahya

@mariembencheikh mariembencheikh Awaiting requested review from mariembencheikh

Assignees

@spaenleh spaenleh

Labels
chore General chore dependencies v2.31.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using Helmet cause warning UNSAFE_componentWillMount
2 participants
@spaenleh @pyphilia