-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove uppy and use upload hooks #1295
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaenleh
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few nitpicks and comments ! Very nice !
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of uppy everywhere. We now use real mutations to upload files for:
My implementation is a mixed of showing upload progress within the drop zone and toaster. The reason is that we sometimes clear the dropzone before the complete upload is finished. Here are the 3 ways we can upload files:
A bug I've noticed is that the backend actually cannot handle multiple files upload (it gets stuck and never return for more than 1 file). Uploading one file is okay, and was actually working with uppy because uppy was sending one file at a time! So I faked this behavior by sending one request per file.
Something that could considered a glitch is "showing n notifications when uploading n files". This is because the notifications are triggered by query client. Personally I think it is okay, but let me know what you think.
Screen.Recording.2024-06-21.at.17.42.55.mov
TODO: