Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update map #1248

Merged
merged 6 commits into from
May 29, 2024
Merged

feat: update map #1248

merged 6 commits into from
May 29, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented May 27, 2024

  • handle correctly inherited geoloc in geoloc form.
  • add viewItemInBuilder

@pyphilia pyphilia self-assigned this May 27, 2024
@pyphilia pyphilia marked this pull request as ready for review May 27, 2024 10:22
@pyphilia pyphilia requested review from spaenleh and ReidyT May 27, 2024 10:22
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 🧱

Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👑

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 768f62a May 29, 2024
4 checks passed
@pyphilia pyphilia deleted the update-map branch May 30, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants