feat: improve publication page #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReidyT
force-pushed
the
1220-improve-publication-page
branch
2 times, most recently
from
9f61832 to
734ed78
Compare
pyphilia
reviewed
May 24, 2024
There was a problem hiding this comment.
Just from viewing videos:
- I understand it is legacy, but it's a bit strange tag and description need to be saved, while the others are auto save. Should we have tag and description be auto saved?
- would be less a pain to add multiple tags at the same time, eventually a preview in the modal, and the close button to finish the operation.
- have a feedback alert banner above publish button once the validate is done. Otherwise people might think nothing changed (I saw the chip changed, but that's a bit discrete). I think this banner can be displayed only if the validation just finished.
- I didn't realise you could make it private after publication lol. Might be interesting to prevent changing visibility once the item is published. (can be another PR)
|
@ReidyT Maybe to fix the regex issue you have with sonarCloud, you could use the |
ReidyT
force-pushed
the
1220-improve-publication-page
branch
2 times, most recently
from
dd8baf0 to
567e5ab
Compare
ReidyT
force-pushed
the
1220-improve-publication-page
branch
4 times, most recently
from
62f91b9 to
e73fedf
Compare
pyphilia
requested changes
Jun 3, 2024
There was a problem hiding this comment.
Wow! Huge PR, it looks good, I like how you split your new files. Maybe it will be one day time to reorganize the folders, the day we don't work on big features on builder^^'
Just a glitch:
https://github.com/graasp/graasp-builder/assets/11229627/62ebd784-16e8-456c-95fa-dc64a2ec4472
Also it might be interesting to have tests for the hooks? if we go torward this nice way of splitting components.
pyphilia
approved these changes
Jun 7, 2024
- feat: add component test to the project - feat: update notifier to enable or not the notifications
ReidyT
force-pushed
the
1220-improve-publication-page
branch
from
b0786d1 to
7e892fe
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final Design
Demo
publish.mov
unpublish_and_outdated.mov
private_published.mov