Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update map, pass parent item #1234

Merged
merged 2 commits into from
May 15, 2024
Merged

feat: update map, pass parent item #1234

merged 2 commits into from
May 15, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented May 13, 2024 •
edited
Loading

Update map, and pass full item parent to the map. Needed to get the permission over the parent.

@pyphilia pyphilia self-assigned this May 13, 2024
@pyphilia pyphilia marked this pull request as ready for review May 15, 2024 07:28
@pyphilia pyphilia requested review from ReidyT and spaenleh May 15, 2024 07:28
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia enabled auto-merge May 15, 2024 08:35
spaenleh
spaenleh approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pyphilia pyphilia added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 3eb32ab May 15, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request May 15, 2024
Merged
@spaenleh spaenleh deleted the map-parent-item branch May 29, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@ReidyT ReidyT Awaiting requested review from ReidyT

Assignees

@pyphilia pyphilia

Labels
v2.22.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyphilia @spaenleh