Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove navigation root and own and shared calls #1211

Merged
merged 4 commits into from
May 3, 2024
Merged

fix: remove navigation root and own and shared calls #1211

merged 4 commits into from
May 3, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented May 2, 2024

Screenshot 2024-05-02 at 14 50 20

I removed the root menu, because it is a pb to use own and shared endpoints. The first arrow is not clickable anymore.

@pyphilia pyphilia requested review from spaenleh, LinaYahya and ReidyT May 2, 2024 12:51
@pyphilia pyphilia self-assigned this May 2, 2024
spaenleh
spaenleh approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good ! Maybe a small nitpick on using Link instead of useNavigate for the home button.

src/components/layout/Navigation.tsx Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia marked this pull request as ready for review May 3, 2024 09:50
@pyphilia pyphilia enabled auto-merge May 3, 2024 09:50
@pyphilia pyphilia added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 4acd5ba May 3, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request May 3, 2024
Merged
@spaenleh spaenleh deleted the remove-navigation-root branch May 6, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@LinaYahya LinaYahya Awaiting requested review from LinaYahya

@ReidyT ReidyT Awaiting requested review from ReidyT

Assignees

@pyphilia pyphilia

Labels
v2.20.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyphilia @spaenleh