-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: redesign add application ui #1188
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for those changes! I think it will really improve the creation of apps!
Some additional design comments:
I have those "margins", I think because of overflowing.
Also I know were not really responsive friendly, but I think it would be good to at least collapse the 2 columns into one on smaller screens.
Hi Kim @pyphilia, I have updated the styles. Could you please check if the margin problems are still there? Thanks a lot. |
I just had two feedback from the testing participants:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work!
Some additional thoughts:
- "the scrollbar should be visible" -> I think it's always visible, do you mean make it even more visible? Wouldn't that be too much?
- Also I think the "create your own application" button is way more too visible, that's the very first thing I see in this modal. Actually it doesn't have to be that highlighted, why not just a little text next to "Need a custom solution ? " for example.
For the first question, on Mac there is a setting set scrollbar invisible by default, that's why users didn't see the scrollbar by default. Thanks for your feedback overall! |
Quality Gate passedIssues Measures |
9c5911d
to
9002bff
Compare
Quality Gate passedIssues Measures |
0791683
to
b513c2f
Compare
In this PR:
CleanShot.2024-04-30.at.11.46.23.mp4