Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve settings page and overall #1184

Merged
merged 9 commits into from
Apr 26, 2024
Merged

fix: improve settings page and overall #1184

merged 9 commits into from
Apr 26, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Apr 24, 2024

Added the "New Item" button option on the drop zone helper:
add new item in dropzone

Home page with transparent table:
table on purple

New settings:
new settings
new settings 2

  • link settings need to be updated and redesigned

fix #1135

Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fan of this "3 options" empty content. What about removing the browse files with new item? For me it makes no sense to have more than one button here. Or use this layout:
image
image

Thanks for all the changes!!! 🍇

package.json Outdated Show resolved Hide resolved
src/components/item/publish/CustomizedTagsEdit.tsx Outdated Show resolved Hide resolved
src/components/item/settings/ClearChatButton.tsx Outdated Show resolved Hide resolved
src/components/item/settings/GeolocationPicker.tsx Outdated Show resolved Hide resolved
src/components/item/settings/ItemLicenseSettings.tsx Outdated Show resolved Hide resolved
src/components/item/settings/ItemMetadataContent.tsx Outdated Show resolved Hide resolved
src/langs/fr.json Outdated Show resolved Hide resolved
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all these improvements, it looks nice !

I agree with Kim concerning the three options to add content on empty folder.
Also, I think it is a little weird the size of the language row comparing to the rest of the table. Maybe it could be nicer to have smaller select ? I have another comment about the select of the language who is not in the center of the row...

Except that, LGTM 👍

@spaenleh
Copy link
Member Author

@ReidyT see graasp/graasp-ui#825 for the centering of the select 😉

@spaenleh
Copy link
Member Author

@pyphilia @ReidyT How about this layout ?
Screenshot 2024-04-25 at 22 36 47

Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah ! I really like the new empty box 👌

package.json Outdated Show resolved Hide resolved
@spaenleh spaenleh requested a review from pyphilia April 26, 2024 08:13
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh enabled auto-merge April 26, 2024 08:44
@spaenleh spaenleh added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit 0f3cb22 Apr 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "or click the 'new item' button to create more elements" to the dropzone helper
3 participants