-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve settings page and overall #1184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all these improvements, it looks nice !
I agree with Kim concerning the three options to add content on empty folder.
Also, I think it is a little weird the size of the language row comparing to the rest of the table. Maybe it could be nicer to have smaller select
? I have another comment about the select of the language who is not in the center of the row...
Except that, LGTM 👍
@ReidyT see graasp/graasp-ui#825 for the centering of the select 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah ! I really like the new empty box 👌
Quality Gate passedIssues Measures |
Added the "New Item" button option on the drop zone helper:
Home page with transparent table:
New settings:
fix #1135