Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update notifs and dismiss uppy status #1120

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Mar 27, 2024

In this PR:

  • dismiss status bar when files are uploaded
  • automatically close new item dialog on file upload complete
  • use stacked notifications for react-toastify
Screen.Recording.2024-03-27.at.16.29.51.mov

@spaenleh spaenleh requested a review from pyphilia March 27, 2024 15:28
@spaenleh spaenleh self-assigned this Mar 27, 2024
@spaenleh spaenleh marked this pull request as draft March 27, 2024 15:28
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@spaenleh spaenleh marked this pull request as ready for review March 28, 2024 15:08
@spaenleh spaenleh force-pushed the 1118-dismiss-uppy-progress branch from 38a0e1d to 812e547 Compare March 28, 2024 15:09
@spaenleh spaenleh enabled auto-merge March 28, 2024 15:09
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh added this pull request to the merge queue Mar 28, 2024
Merged via the queue into main with commit 571ddc2 Mar 28, 2024
4 checks passed
ztlee042 pushed a commit that referenced this pull request Apr 4, 2024
* fix: dismiss uppy status on complete and use stacked notifs

* fix: add on complete close new item modal
@spaenleh spaenleh deleted the 1118-dismiss-uppy-progress branch April 5, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants