Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename chatbox title #1094

Merged
merged 6 commits into from
Mar 26, 2024
Merged

fix: rename chatbox title #1094

merged 6 commits into from
Mar 26, 2024

Conversation

mariembencheikh
Copy link
Contributor

@mariembencheikh mariembencheikh commented Mar 21, 2024 •
edited
Loading

fix #986

@mariembencheikh mariembencheikh self-assigned this Mar 21, 2024
spaenleh
spaenleh requested changes Mar 22, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first PR. 🎉

I have added a comment. I think you should use interpolation. Let me know if you have questions or doubts.

src/components/item/ItemMain.tsx Outdated Show resolved Hide resolved
spaenleh
spaenleh requested changes Mar 22, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use the interpolation from the i18next library. See the link in my last comment.

src/langs/fr.json Outdated Show resolved Hide resolved
src/components/item/ItemMain.tsx Outdated Show resolved Hide resolved
mariembencheikh and others added 2 commits March 22, 2024 15:34
@mariembencheikh @spaenleh
Update src/langs/fr.json
943b484 
Co-authored-by: Basile Spaenlehauer <[email protected]>
@mariembencheikh @spaenleh
Update src/components/item/ItemMain.tsx
4df3516 
Co-authored-by: Basile Spaenlehauer <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

spaenleh
spaenleh approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎄

@mariembencheikh mariembencheikh added this pull request to the merge queue Mar 26, 2024
Merged via the queue into main with commit 4cef3af Mar 26, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Mar 25, 2024
Merged
ztlee042 pushed a commit that referenced this pull request Apr 4, 2024
@mariembencheikh @spaenleh @ztlee042
fix: rename chatbox title (#1094)
7f2d74d 
* fix: rename chatbox title

* fix: rename chatbox title

* fix: rename the chatbox drawer title to Item name chat

* Update src/langs/fr.json

Co-authored-by: Basile Spaenlehauer <[email protected]>

* Update src/components/item/ItemMain.tsx

Co-authored-by: Basile Spaenlehauer <[email protected]>

* fix: rename the chatbox drawer title to Itemname chat

---------

Co-authored-by: Basile Spaenlehauer <[email protected]>
@spaenleh spaenleh deleted the 986-rename-chatbox-title branch April 5, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees

@mariembencheikh mariembencheikh

Labels
improvement v2.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename the chatbox drawer title to "Item name" chat
2 participants
@mariembencheikh @spaenleh