-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update mode button, refactor #1030
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinaYahya
approved these changes
Feb 23, 2024
pyphilia
force-pushed
the
layout-name-hook
branch
from
February 27, 2024 15:47
93c663a
to
e6c5f3a
Compare
pyphilia
changed the title
refactor: update mode button, refactor
feat: update mode button, refactor
Feb 27, 2024
spaenleh
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
pyphilia
force-pushed
the
layout-name-hook
branch
from
February 28, 2024 15:40
e6c5f3a
to
b880005
Compare
Quality Gate passedIssues Measures |
spaenleh
pushed a commit
that referenced
this pull request
Mar 11, 2024
feat(dropzone): modify parent divs heights feat(dropzone): add dropzone helper feat(dropzone): modify text fix(dropzone): hide dropzone in favorite screen feat(dropzone): add prop to control dropzone helper visibility fix(dropzone): modify redirection test to match dropzone behavior fix(dropzone): add id, change styles and texts feat: update mode button, refactor (#1030) * refactor: update mode button, refactor * refactor: apply PR requested changes * refactor: update cypress * refactor: mock item layout in commands * refactor: import automatically env in cypress * refactor: env in cypress * refactor: import VITE_GRAASP_REDIRECTION_HOST * refactor: use cypress baseurl feat: move the description in ItemsToolbar to display it directly below the title (#1045) chore(deps): update eslint packages (#1034) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix(deps): update ag-grid monorepo to v31.1.1 (#1035) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix(deps): update dependency @emotion/react to v11.11.4 (#1036) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix(deps): update dependency @sentry/react to v7.105.0 (#1037) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix(deps): update react-router monorepo to v6.22.2 (#1023) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix(deps): update mui (non-major) (#884) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix: remove qs dependency (#1041) * fix: remove qs dependency * fix: update deps chore(deps): update yarn to v4.1.1 (#1052) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> chore(deps): update eslint packages to v7.1.1 (#1051) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix: remove duplicate none doc flavor (#1055) chore(main): release 2.9.0 (#1043) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix(deps): update dependency @graasp/ui to v4.8.5 (#1046) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> chore(main): release 2.9.1 (#1062) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix: revert previous published item layout (#1058) * fix: revert previous published item layout * refactor: fix publish button chore(main): release 2.9.2 (#1063) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix: fix mobile platform switch colors (#1064) chore(main): release 2.9.3 (#1065) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix: invert colors for mobile platform switch (#1066) chore(main): release 2.9.4 (#1069) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> feat(dropzone): hide dropzone when use has no permission fix(dropzone): home screen styling test(dropzone): add dropzone tests
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
* feat(dropzone): add helper texts feat(dropzone): modify parent divs heights feat(dropzone): add dropzone helper feat(dropzone): modify text fix(dropzone): hide dropzone in favorite screen feat(dropzone): add prop to control dropzone helper visibility fix(dropzone): modify redirection test to match dropzone behavior fix(dropzone): add id, change styles and texts feat: update mode button, refactor (#1030) * refactor: update mode button, refactor * refactor: apply PR requested changes * refactor: update cypress * refactor: mock item layout in commands * refactor: import automatically env in cypress * refactor: env in cypress * refactor: import VITE_GRAASP_REDIRECTION_HOST * refactor: use cypress baseurl feat: move the description in ItemsToolbar to display it directly below the title (#1045) chore(deps): update eslint packages (#1034) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix(deps): update ag-grid monorepo to v31.1.1 (#1035) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix(deps): update dependency @emotion/react to v11.11.4 (#1036) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix(deps): update dependency @sentry/react to v7.105.0 (#1037) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix(deps): update react-router monorepo to v6.22.2 (#1023) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix(deps): update mui (non-major) (#884) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix: remove qs dependency (#1041) * fix: remove qs dependency * fix: update deps chore(deps): update yarn to v4.1.1 (#1052) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> chore(deps): update eslint packages to v7.1.1 (#1051) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix: remove duplicate none doc flavor (#1055) chore(main): release 2.9.0 (#1043) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix(deps): update dependency @graasp/ui to v4.8.5 (#1046) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> chore(main): release 2.9.1 (#1062) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix: revert previous published item layout (#1058) * fix: revert previous published item layout * refactor: fix publish button chore(main): release 2.9.2 (#1063) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix: fix mobile platform switch colors (#1064) chore(main): release 2.9.3 (#1065) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix: invert colors for mobile platform switch (#1066) chore(main): release 2.9.4 (#1069) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> feat(dropzone): hide dropzone when use has no permission fix(dropzone): home screen styling test(dropzone): add dropzone tests * fix: update test descriptions --------- Co-authored-by: spaenleh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ItemLayoutMode
ModeButton
useGetPermissionForItem
, that will be replaced at some point, but at least it cleaned some old codeclose #1012