Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update mode button, refactor #1030

Merged
merged 8 commits into from
Feb 29, 2024
Merged

feat: update mode button, refactor #1030

merged 8 commits into from
Feb 29, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Feb 22, 2024

  • rename ItemLayoutMode
  • Refactor ModeButton
  • use useGetPermissionForItem, that will be replaced at some point, but at least it cleaned some old code
Screenshot 2024-02-22 at 16 43 11

close #1012

@pyphilia pyphilia marked this pull request as ready for review February 22, 2024 15:47
@pyphilia pyphilia changed the title refactor: update mode button, refactor feat: update mode button, refactor Feb 27, 2024
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

src/components/item/header/ModeButton.tsx Outdated Show resolved Hide resolved
src/config/env.ts Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
3.1% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit 1ee57ef Feb 29, 2024
4 checks passed
@spaenleh spaenleh deleted the layout-name-hook branch March 6, 2024 10:09
spaenleh pushed a commit that referenced this pull request Mar 11, 2024
feat(dropzone): modify parent divs heights

feat(dropzone): add dropzone helper

feat(dropzone): modify text

fix(dropzone): hide dropzone in favorite screen

feat(dropzone): add prop to control dropzone helper visibility

fix(dropzone): modify redirection test to match dropzone behavior

fix(dropzone): add id, change styles and texts

feat: update mode button, refactor (#1030)

* refactor: update mode button, refactor

* refactor: apply PR requested changes

* refactor: update cypress

* refactor: mock item layout in commands

* refactor: import automatically env in cypress

* refactor: env in cypress

* refactor: import VITE_GRAASP_REDIRECTION_HOST

* refactor: use cypress baseurl

feat: move the description in ItemsToolbar to display it directly below the title (#1045)

chore(deps): update eslint packages (#1034)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update ag-grid monorepo to v31.1.1 (#1035)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency @emotion/react to v11.11.4 (#1036)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency @sentry/react to v7.105.0 (#1037)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update react-router monorepo to v6.22.2 (#1023)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update mui (non-major) (#884)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix: remove qs dependency (#1041)

* fix: remove qs dependency

* fix: update deps

chore(deps): update yarn to v4.1.1 (#1052)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update eslint packages to v7.1.1 (#1051)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix: remove duplicate none doc flavor (#1055)

chore(main): release 2.9.0 (#1043)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix(deps): update dependency @graasp/ui to v4.8.5 (#1046)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(main): release 2.9.1 (#1062)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: revert previous published item layout (#1058)

* fix: revert previous published item layout

* refactor: fix publish button

chore(main): release 2.9.2 (#1063)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: fix mobile platform switch colors (#1064)

chore(main): release 2.9.3 (#1065)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: invert colors for mobile platform switch (#1066)

chore(main): release 2.9.4 (#1069)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

feat(dropzone): hide dropzone when use has no permission

fix(dropzone): home screen styling

test(dropzone): add dropzone tests
github-merge-queue bot pushed a commit that referenced this pull request Mar 11, 2024
* feat(dropzone): add helper texts

feat(dropzone): modify parent divs heights

feat(dropzone): add dropzone helper

feat(dropzone): modify text

fix(dropzone): hide dropzone in favorite screen

feat(dropzone): add prop to control dropzone helper visibility

fix(dropzone): modify redirection test to match dropzone behavior

fix(dropzone): add id, change styles and texts

feat: update mode button, refactor (#1030)

* refactor: update mode button, refactor

* refactor: apply PR requested changes

* refactor: update cypress

* refactor: mock item layout in commands

* refactor: import automatically env in cypress

* refactor: env in cypress

* refactor: import VITE_GRAASP_REDIRECTION_HOST

* refactor: use cypress baseurl

feat: move the description in ItemsToolbar to display it directly below the title (#1045)

chore(deps): update eslint packages (#1034)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update ag-grid monorepo to v31.1.1 (#1035)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency @emotion/react to v11.11.4 (#1036)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency @sentry/react to v7.105.0 (#1037)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update react-router monorepo to v6.22.2 (#1023)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update mui (non-major) (#884)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix: remove qs dependency (#1041)

* fix: remove qs dependency

* fix: update deps

chore(deps): update yarn to v4.1.1 (#1052)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update eslint packages to v7.1.1 (#1051)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix: remove duplicate none doc flavor (#1055)

chore(main): release 2.9.0 (#1043)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix(deps): update dependency @graasp/ui to v4.8.5 (#1046)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(main): release 2.9.1 (#1062)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: revert previous published item layout (#1058)

* fix: revert previous published item layout

* refactor: fix publish button

chore(main): release 2.9.2 (#1063)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: fix mobile platform switch colors (#1064)

chore(main): release 2.9.3 (#1065)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: invert colors for mobile platform switch (#1066)

chore(main): release 2.9.4 (#1069)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

feat(dropzone): hide dropzone when use has no permission

fix(dropzone): home screen styling

test(dropzone): add dropzone tests

* fix: update test descriptions

---------

Co-authored-by: spaenleh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace and use useCanUpdateItem
3 participants