Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memberships table does not re-render when memberships change #935

Closed
spaenleh opened this issue Jan 9, 2024 · 0 comments
Closed

Memberships table does not re-render when memberships change #935

spaenleh opened this issue Jan 9, 2024 · 0 comments
Labels

Comments

@spaenleh
Copy link
Member

spaenleh commented Jan 9, 2024

When a membership changes, the other rows of the table do not re-render.
This is an issue if for example you remove the last before admin, then the hasOnlyOneAdmin will not pass to true and there will be no safety to remove the last admin in the frontend.

Solution

Add the memberships to the useMemo dependencies in ItemMembershipsTable.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant