feat: disable options for downgrading the only admin #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaenleh
requested changes
Jan 8, 2024
There was a problem hiding this comment.
Thank you for this PR 🧩
Please see my comments. I had a bit of trouble understanding how the disabled permissions are computed. Could we have maybe more comments and examples of input outputs that are expected, i.e. if the user has permission write the admin value should be disabled, if the user is the last admin all permissions should be disabled.
|
@LinaYahya I propose some changes. I also found a bug with the useMemo dependencies that made the select not update its state when adding/removing another admin. This has been fixed. |
spaenleh
approved these changes
Jan 9, 2024
…902-disable-forbidden-permission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #902