Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve breadcrumbs using graasp-ui #664

Closed
pyphilia opened this issue Jun 21, 2023 · 0 comments · Fixed by #679
Closed

Improve breadcrumbs using graasp-ui #664

pyphilia opened this issue Jun 21, 2023 · 0 comments · Fixed by #679
Assignees
Labels

Comments

@pyphilia
Copy link
Contributor

No description provided.

@pyphilia pyphilia self-assigned this Jun 21, 2023
ReidyT added a commit that referenced this issue Nov 3, 2023
- The view is not responsive yet
- Contain problems yet with the SDK and the query-client
spaenleh pushed a commit that referenced this issue Nov 3, 2023
- The view is not responsive yet
- Contain problems yet with the SDK and the query-client
spaenleh pushed a commit that referenced this issue Nov 3, 2023
- The view is not responsive yet
- Contain problems yet with the SDK and the query-client
ReidyT added a commit that referenced this issue Nov 10, 2023
- The view is not responsive yet
- Contain problems yet with the SDK and the query-client
ReidyT added a commit that referenced this issue Nov 14, 2023
- The view is not responsive yet
- Contain problems yet with the SDK and the query-client
ReidyT added a commit that referenced this issue Nov 30, 2023
- The view is not responsive yet
- Contain problems yet with the SDK and the query-client
spaenleh pushed a commit that referenced this issue Dec 1, 2023
- The view is not responsive yet
- Contain problems yet with the SDK and the query-client

feat: improve UI, add translations and messages (graasp/graasp#664)
- Update the UI to be more responsive
- Update the UI to not allow to edit or create multiple short links at same time
- Add membership admin check to hide short links view if forbbiden
- Add notifier for short links actions and show error messages to the user

feat: add Context colours in ShortLink view and use last SDK types

test: add short links cypress tests (graasp/graasp#664)

chore: add ENV variable for redirection host

fix(test): remove shortLinkRenderId should exist to pass in CI

chore: improve code form PR (#861)
- Remove unnecessary nested cypress waits
- Check the item path too in the isItemAdminAllowedForMember
- Add Skeleton when loading short links
- Allow to use Library platform for published items only
- Update checkShortLink by shortLinkAvailable
- Split ManageShortLink into smaller components
- Remove not null assertions

test: try to debug cypress in CI

fix: add redirection host environment variable in cypress CI

feat: update short links to future merge with full links

feat: add shortlinks skeletons and move ManageShortLink dialog to parent

feat: allow readers to display short links in read only mode

feat: remove ShareItem component

chore: update query-client, sdk and translations NPM version
- query-client v2.1.0
- sdk v3.2.0
- translations v1.21.0

test: udpate the shortlink test for read only members

chore: improve the code from the PR #861
- Update the redirection host to the short link’s backend route (go.graasp.org for prod)
- Update mockGetShortLinksItem to filter by item id
- Update SDK version
- Adding changeVisibility test (part of tests from deleted shareItem)
- Update shareItem tests to test short links displayed links
- Moved short link test into share folder
- Replace alias by short link in translations
- Translates alias input
- Replace aliasUnchanged state by hasAliasChanged in ShortLinkDialogContent
- Regroup the useEffect in AliasValidation
- Set GraaspLogo as default icon when PlatformIcon get invalid platform
- Encapsulate debounce of API calls in a custom hooks
- Others minor improvements

chore: improve aliasAvailable check and make the item's platforms static
- Use Boolean wrapper to check the aliasAvailable in AliasValidation.tsx
- Set the item’s platforms static in the ShortLinkRenderer.tsx
spaenleh added a commit that referenced this issue Dec 1, 2023
* feat: add short links view (#664)
- The view is not responsive yet
- Contain problems yet with the SDK and the query-client

feat: improve UI, add translations and messages (graasp/graasp#664)
- Update the UI to be more responsive
- Update the UI to not allow to edit or create multiple short links at same time
- Add membership admin check to hide short links view if forbbiden
- Add notifier for short links actions and show error messages to the user

feat: add Context colours in ShortLink view and use last SDK types

test: add short links cypress tests (graasp/graasp#664)

chore: add ENV variable for redirection host

fix(test): remove shortLinkRenderId should exist to pass in CI

chore: improve code form PR (#861)
- Remove unnecessary nested cypress waits
- Check the item path too in the isItemAdminAllowedForMember
- Add Skeleton when loading short links
- Allow to use Library platform for published items only
- Update checkShortLink by shortLinkAvailable
- Split ManageShortLink into smaller components
- Remove not null assertions

test: try to debug cypress in CI

fix: add redirection host environment variable in cypress CI

feat: update short links to future merge with full links

feat: add shortlinks skeletons and move ManageShortLink dialog to parent

feat: allow readers to display short links in read only mode

feat: remove ShareItem component

chore: update query-client, sdk and translations NPM version
- query-client v2.1.0
- sdk v3.2.0
- translations v1.21.0

test: udpate the shortlink test for read only members

chore: improve the code from the PR #861
- Update the redirection host to the short link’s backend route (go.graasp.org for prod)
- Update mockGetShortLinksItem to filter by item id
- Update SDK version
- Adding changeVisibility test (part of tests from deleted shareItem)
- Update shareItem tests to test short links displayed links
- Moved short link test into share folder
- Replace alias by short link in translations
- Translates alias input
- Replace aliasUnchanged state by hasAliasChanged in ShortLinkDialogContent
- Regroup the useEffect in AliasValidation
- Set GraaspLogo as default icon when PlatformIcon get invalid platform
- Encapsulate debounce of API calls in a custom hooks
- Others minor improvements

chore: improve aliasAvailable check and make the item's platforms static
- Use Boolean wrapper to check the aliasAvailable in AliasValidation.tsx
- Set the item’s platforms static in the ShortLinkRenderer.tsx

* fix(test): use an id for custom app instead of translated name

* fix: use translated text for flag item button content

---------

Co-authored-by: spaenleh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant