Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve accessibility for mainmenu and table #555

Merged
merged 1 commit into from
Feb 14, 2023
Merged

feat: improve accessibility for mainmenu and table #555

merged 1 commit into from
Feb 14, 2023

Conversation

pyphilia
Copy link
Contributor

close #554

@pyphilia pyphilia requested a review from spaenleh February 13, 2023 08:34
@pyphilia pyphilia self-assigned this Feb 13, 2023
spaenleh
spaenleh approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this ! Looks good ! 🪬

@pyphilia pyphilia merged commit 9cdac8d into main Feb 14, 2023
pyphilia added a commit that referenced this pull request Feb 14, 2023
@pyphilia
Revert "feat: improve accessibility for mainmenu and table (#555)"
7343862 
This reverts commit 9cdac8d.
@github-actions github-actions bot mentioned this pull request Feb 14, 2023
Merged
@pyphilia pyphilia deleted the 554-graasp-ui-a11y branch February 14, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

Assignees

@pyphilia pyphilia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update graasp-ui and add more accessibility
2 participants
@pyphilia @spaenleh