Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: case-insensitive autocomplete comparison #529

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

spaenleh
Copy link
Member

This PR fixes dumb issues created in #514:

  • comparison of the strings should be made in lowercase
  • resizable setting should be show when ItemType is app

closes #528

fix: setting is not applied to app
@spaenleh spaenleh added the bug 🪲 Something isn't working label Jan 12, 2023
@spaenleh spaenleh self-assigned this Jan 12, 2023
@spaenleh spaenleh linked an issue Jan 12, 2023 that may be closed by this pull request
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏋️

src/components/item/settings/ItemSettings.tsx Show resolved Hide resolved
@spaenleh spaenleh merged commit 2f496bb into main Jan 16, 2023
@spaenleh spaenleh deleted the 528-fix-case-insensitive-autocomplete branch January 16, 2023 08:52
@spaenleh spaenleh added the v0.4.0 feat: resizable, fix: app auto-complete label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working v0.4.0 feat: resizable, fix: app auto-complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix case-insensitive autocomplete
2 participants