Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multi op for home, recycle bin, folder screens #1354

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Jul 17, 2024

I added back a toolbar that shows when at least one item is selected.

One can select an item by clicking on the thumbnail (originally all the card, but I add conflicts with the op buttons on the right (menu item, bookmark, etc)) so I fallbacked to the thumbnail only.
We can also drag-select many items. There's no cmd/ctrl functionality (yet).

Features:

  • home screen
    • copy
    • move
    • recycle
  • folder screen
    • copy
    • move
    • recycle
  • recycle bin
    • delete
    • restore

Not in this PR: we cannot reorder many items

TODO

  • drag multiple items in item
  • tests
Screen.Recording.2024-07-22.at.15.06.29.mov
Screen.Recording.2024-07-22.at.15.05.40.mov
Screen.Recording.2024-07-22.at.15.04.58.mov

close #1342

@pyphilia pyphilia self-assigned this Jul 17, 2024
@pyphilia pyphilia marked this pull request as ready for review July 22, 2024 10:35
@spaenleh spaenleh changed the title feat: add multi op for hom, recycle bin, folder screens feat: add multi op for home, recycle bin, folder screens Jul 23, 2024
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the work !

cypress/e2e/item/bookmarks/bookmarks.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/item/copy/copy.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/item/move/move.cy.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/main/list/SelectionToolbar.tsx Show resolved Hide resolved
src/components/pages/RecycledItemsScreen.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this very nice PR! LGTM, I just let some comments 😶‍🌫️

src/components/item/FolderContent.tsx Outdated Show resolved Hide resolved
src/components/item/FolderContent.tsx Show resolved Hide resolved
src/components/item/FolderContent.tsx Show resolved Hide resolved
src/components/item/FolderContent.tsx Outdated Show resolved Hide resolved
src/components/main/DeleteItemDialog.tsx Outdated Show resolved Hide resolved
src/components/main/list/ItemsTable.tsx Outdated Show resolved Hide resolved
src/components/main/list/ItemsTable.tsx Outdated Show resolved Hide resolved
src/components/main/list/ItemsTableCard.tsx Outdated Show resolved Hide resolved
src/components/main/list/SelectionContext.tsx Outdated Show resolved Hide resolved
src/components/pages/RecycledItemsScreen.tsx Outdated Show resolved Hide resolved
Copy link

@pyphilia pyphilia enabled auto-merge July 24, 2024 11:12
@pyphilia pyphilia added this pull request to the merge queue Jul 24, 2024
Merged via the queue into main with commit 3440849 Jul 24, 2024
4 checks passed
@pyphilia pyphilia deleted the multi-select branch August 5, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow multi move/copy/recycle/delete/restore
3 participants