Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: redesign add link interface #1165

Merged
merged 15 commits into from
May 28, 2024
Merged

feat: redesign add link interface #1165

merged 15 commits into from
May 28, 2024

Conversation

ztlee042
Copy link
Contributor

@ztlee042 ztlee042 commented Apr 18, 2024 •
edited by spaenleh
Loading

#1162

In this PR:

  • LinkForm is improved to provide more information

@spaenleh spaenleh force-pushed the 1162-add-link-modal branch from ed5683a to 52adafb Compare May 7, 2024 09:14
@spaenleh spaenleh force-pushed the 1162-add-link-modal branch 2 times, most recently from 57b98ab to 5cc6802 Compare May 22, 2024 06:42
@spaenleh spaenleh marked this pull request as ready for review May 22, 2024 14:15
@spaenleh spaenleh self-assigned this May 24, 2024
@spaenleh spaenleh added the feature New feature or request label May 24, 2024
@spaenleh spaenleh requested review from pyphilia and ReidyT May 24, 2024 13:05
@spaenleh spaenleh force-pushed the 1162-add-link-modal branch from d842608 to 6def37b Compare May 24, 2024 13:49
ReidyT
ReidyT requested changes May 24, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR ! I think we could remove unused props and maybe we can try to refactor the LinkForm to have smaller components or extracting some logic ? What do you think ?

cypress/support/viewUtils.ts Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/item/form/link/LinkForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/link/LinkForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/link/LinkForm.tsx Show resolved Hide resolved
src/components/item/form/link/LinkForm.tsx Show resolved Hide resolved
@spaenleh spaenleh requested a review from ReidyT May 28, 2024 07:23
ReidyT
ReidyT approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this refactor 😆, LGTM 🚀🙌

@spaenleh spaenleh added this pull request to the merge queue May 28, 2024
@spaenleh spaenleh removed this pull request from the merge queue due to a manual request May 28, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 36e7511 May 28, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request May 28, 2024
Merged
@spaenleh spaenleh deleted the 1162-add-link-modal branch May 29, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh left review comments

@ReidyT ReidyT ReidyT approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees

@spaenleh spaenleh

Labels
feature New feature or request v2.24.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ztlee042 @spaenleh @ReidyT