fix: update ui

graasp · May 22, 2024 · 5cc6802 · 5cc6802
1 parent f5f42b8
commit 5cc6802
Show file tree

Hide file tree

Showing 2 changed files with 123 additions and 112 deletions.
diff --git a/src/components/item/form/link/LinkForm.tsx b/src/components/item/form/link/LinkForm.tsx
@@ -161,11 +161,19 @@ const LinkForm = ({
   // this is only run once.
   useEffect(
     () => {
+      // this is the object on which we will define the props to be updated
+      const updatedProps: Partial<DiscriminatedItem> = {};
+
       if (!isDescriptionDirty && linkData?.description) {
-        onChange({ description: linkData?.description });
+        updatedProps.description = linkData?.description;
       }
       if (linkData?.title) {
-        onChange({ name: linkData.title });
+        updatedProps.name = linkData.title;
+      }
+      // update props in one call to remove issue of race updates
+      if (Object.keys(updatedProps).length) {
+        // this should be called only once !
+        onChange(updatedProps);
       }
     },
     // eslint-disable-next-line react-hooks/exhaustive-deps
@@ -258,17 +266,19 @@ const LinkForm = ({
         InputProps={{
           endAdornment: (
             <>
-              <IconButton
-                onClick={onClickRestoreDefaultDescription}
-                sx={{
-                  visibility:
-                    description !== linkData?.description
-                      ? 'visible'
-                      : 'hidden',
-                }}
-              >
-                <Undo2Icon size="20" />
-              </IconButton>
+              {isDescriptionDirty ? (
+                <IconButton
+                  onClick={onClickRestoreDefaultDescription}
+                  sx={{
+                    visibility:
+                      description !== linkData?.description
+                        ? 'visible'
+                        : 'hidden',
+                  }}
+                >
+                  <Undo2Icon size="20" />
+                </IconButton>
+              ) : undefined}
               <IconButton
                 onClick={onClickClearDescription}
                 sx={{