feat: add dropzone header #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaenleh
requested changes
Mar 4, 2024
There was a problem hiding this comment.
Thank you for this PR. 🐨
I added some comments related to how we usually style components.
Please address the following before re-requesting a review:
- fix existing tests that are broken by the feature and should be fixed to match the new behaviour
- add tests that test the new feature
- fix styling question on small screens
Also, this new component now appears in the following places:
- Shared Items (if the user has no shared items)
- Favorite Items (if the user has no favorite items)
- Published Items (if the user has no published items)
- Trash (if the user has no items in the bin)
The message should not be displayed in those places.
You should address this as we do not allow to upload files on the shared items screen for example.
Let me know if you have questions or doubts.
feat(dropzone): modify parent divs heights feat(dropzone): add dropzone helper feat(dropzone): modify text fix(dropzone): hide dropzone in favorite screen feat(dropzone): add prop to control dropzone helper visibility fix(dropzone): modify redirection test to match dropzone behavior fix(dropzone): add id, change styles and texts feat: update mode button, refactor (#1030) * refactor: update mode button, refactor * refactor: apply PR requested changes * refactor: update cypress * refactor: mock item layout in commands * refactor: import automatically env in cypress * refactor: env in cypress * refactor: import VITE_GRAASP_REDIRECTION_HOST * refactor: use cypress baseurl feat: move the description in ItemsToolbar to display it directly below the title (#1045) chore(deps): update eslint packages (#1034) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix(deps): update ag-grid monorepo to v31.1.1 (#1035) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix(deps): update dependency @emotion/react to v11.11.4 (#1036) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix(deps): update dependency @sentry/react to v7.105.0 (#1037) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix(deps): update react-router monorepo to v6.22.2 (#1023) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix(deps): update mui (non-major) (#884) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix: remove qs dependency (#1041) * fix: remove qs dependency * fix: update deps chore(deps): update yarn to v4.1.1 (#1052) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> chore(deps): update eslint packages to v7.1.1 (#1051) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> fix: remove duplicate none doc flavor (#1055) chore(main): release 2.9.0 (#1043) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix(deps): update dependency @graasp/ui to v4.8.5 (#1046) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> chore(main): release 2.9.1 (#1062) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix: revert previous published item layout (#1058) * fix: revert previous published item layout * refactor: fix publish button chore(main): release 2.9.2 (#1063) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix: fix mobile platform switch colors (#1064) chore(main): release 2.9.3 (#1065) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix: invert colors for mobile platform switch (#1066) chore(main): release 2.9.4 (#1069) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> feat(dropzone): hide dropzone when use has no permission fix(dropzone): home screen styling test(dropzone): add dropzone tests
spaenleh
force-pushed
the
1040-dropzone-header
branch
from
0f2550a to
bfc4e2f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1040