fix: add redirection host environment variable in cypress CI

graasp · Nov 20, 2023 · cd4f3f7 · cd4f3f7
1 parent cefdf33
commit cd4f3f7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/cypress.yml b/.github/workflows/cypress.yml
@@ -43,6 +43,7 @@ jobs:
           VITE_GRAASP_LIBRARY_HOST: ${{ vars.VITE_GRAASP_LIBRARY_HOST }}
           VITE_GRAASP_ANALYZER_HOST: ${{ vars.VITE_GRAASP_ANALYZER_HOST }}
           VITE_SHOW_NOTIFICATIONS: ${{ vars.VITE_SHOW_NOTIFICATIONS }}
+          VITE_GRAASP_REDIRECTION_HOST: "http://localhost:3030"
 
       #  use the Cypress GitHub Action to run Cypress tests within the chrome browser
       - name: Cypress run
@@ -66,6 +67,8 @@ jobs:
           VITE_GRAASP_LIBRARY_HOST: ${{ vars.VITE_GRAASP_LIBRARY_HOST }}
           VITE_GRAASP_ANALYZER_HOST: ${{ vars.VITE_GRAASP_ANALYZER_HOST }}
           VITE_SHOW_NOTIFICATIONS: ${{ vars.VITE_SHOW_NOTIFICATIONS }}
+          # TODO: add REDIRECTION_HOST !
+          VITE_GRAASP_REDIRECTION_HOST: "http://localhost:3030"
 
       # after the test run completes
       # store any screenshots

diff --git a/cypress/e2e/item/shortLink/shortLink.cy.ts b/cypress/e2e/item/shortLink/shortLink.cy.ts
@@ -140,7 +140,7 @@ describe('Short links', () => {
 
       it('Patch short link', () => {
         const NEW_SHORT_LINK = 'test-10';
-        const NEW_PLATFORM = Context.Library;
+        const NEW_PLATFORM = Context.Builder;
         const PATCH_ALIAS = shortLinks[0].alias;
 
         cy.visit(buildItemPath(itemId));
@@ -185,7 +185,7 @@ describe('Short links', () => {
       });
 
       it('Patch short link with random alias', () => {
-        const NEW_PLATFORM = Context.Library;
+        const NEW_PLATFORM = Context.Builder;
         const PATCH_ALIAS = shortLinks[0].alias;
 
         cy.visit(buildItemPath(itemId));

diff --git a/src/components/App.tsx b/src/components/App.tsx
@@ -4,6 +4,7 @@ import { Route, Routes } from 'react-router-dom';
 import { saveUrlForRedirection } from '@graasp/sdk';
 import { CustomInitialLoader, withAuthorization } from '@graasp/ui';
 
+// TODO: uncomments Sentry code
 // import * as Sentry from '@sentry/react';
 import { DOMAIN } from '@/config/env';
 import { SIGN_IN_PATH } from '@/config/externalPaths';