Skip to content

Commit

Permalink
fix: bump ui and re-enable chrome tests (#805)
Browse files Browse the repository at this point in the history
  • Loading branch information
spaenleh authored Oct 4, 2023
1 parent 046bc5e commit a4a023e
Show file tree
Hide file tree
Showing 4 changed files with 1,132 additions and 1,457 deletions.
1 change: 1 addition & 0 deletions .github/workflows/cypress.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ jobs:
install: false
# we launch the app in preview mode to avoid issues with hmr websockets from vite polluting the mocks
start: yarn preview:test
browser: chrome
quiet: true
config-file: cypress.config.ts
cache-key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
Expand Down
9 changes: 4 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"@graasp/query-client": "1.8.2",
"@graasp/sdk": "1.6.0",
"@graasp/translations": "1.19.0",
"@graasp/ui": "3.5.1",
"@graasp/ui": "3.5.3",
"@mui/icons-material": "5.14.6",
"@mui/lab": "5.0.0-alpha.141",
"@mui/material": "5.14.6",
Expand Down Expand Up @@ -86,9 +86,8 @@
"hooks:uninstall": "husky uninstall",
"hooks:install": "husky install",
"cypress:open": "env-cmd -f ./.env.test cypress open --browser chrome",
"cypress": "yarn test",
"test": "yarn build:test && concurrently -k -s first \"yarn preview:test\" \"yarn cypress:run\"",
"cypress:run": "env-cmd -f ./.env.test cypress run --headless --browser chrome",
"cypress:run": "env-cmd -f ./.env.test cypress run --browser chrome",
"postinstall": "husky install"
},
"browserslist": {
Expand Down Expand Up @@ -117,7 +116,7 @@
"@types/node": "18.17.12",
"@types/papaparse": "5.3.8",
"@types/qs": "6.9.7",
"@types/react": "18.2.21",
"@types/react": "18.2.22",
"@types/react-csv": "1.1.3",
"@types/react-dom": "18.2.7",
"@types/uuid": "9.0.2",
Expand All @@ -126,7 +125,7 @@
"@typescript-eslint/parser": "6.5.0",
"@vitejs/plugin-react": "4.0.4",
"concurrently": "8.2.1",
"cypress": "13.2.0",
"cypress": "13.3.0",
"cypress-localstorage-commands": "2.2.4",
"env-cmd": "10.1.0",
"eslint": "^8.47.0",
Expand Down
5 changes: 0 additions & 5 deletions src/components/main/ItemScreen.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ const ItemScreen = (): JSX.Element => {
};

const WrappedItemScreen = (): JSX.Element => {
const { mutate: signOut } = mutations.useSignOut();
const { mutate: itemLoginSignIn } = mutations.usePostItemLogin();
const itemId = useShortenURLParams(ITEM_ID_PARAMS);

Expand All @@ -116,10 +115,6 @@ const WrappedItemScreen = (): JSX.Element => {

const Component = ItemLoginAuthorization({
signIn: itemLoginSignIn,
// todo: remove when ui is updated
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
signOut,
itemId,
useCurrentMember,
useItem,
Expand Down
Loading

0 comments on commit a4a023e

Please sign in to comment.