fix: move umami website id to vars

graasp · Oct 7, 2024 · 8441d42 · 8441d42
1 parent 4165b7e
commit 8441d42
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/deploy-dev.yml b/.github/workflows/deploy-dev.yml
@@ -40,6 +40,7 @@ jobs:
           # VITE_GA_MEASUREMENT_ID: ${{ secrets.VITE_GA_MEASUREMENT_ID }}
           VITE_SHOW_NOTIFICATIONS: ${{ vars.VITE_SHOW_NOTIFICATIONS }}
           VITE_GRAASP_REDIRECTION_HOST: ${{ vars.VITE_GRAASP_REDIRECTION_HOST }}
+          VITE_UMAMI_WEBSITE_ID: ${{ vars.VITE_UMAMI_WEBSITE_ID }}
         run: yarn build
         shell: bash
 

diff --git a/index.html b/index.html
@@ -20,12 +20,15 @@
     />
 
     <!-- Umami tracking code -->
-    <!-- TODO: use an env var -->
+
+    <!--
+    The integrity can not be checked when using cross origin
+    integrity="sha384-JyQQf9XxkMfVx/h+OQ+SxUZqLbL3p3KmWfnZ4LpQWzksmzHXESgXCk1/5AYxT9nR"
+    -->
     <script
       defer
       src="https://cloud.umami.is/script.js"
-      data-website-id="46068c2d-17a3-4fe2-a1f0-1a0e992711f8"
-      integrity="sha384-JyQQf9XxkMfVx/h+OQ+SxUZqLbL3p3KmWfnZ4LpQWzksmzHXESgXCk1/5AYxT9nR"
+      data-website-id="%VITE_UMAMI_WEBSITE_ID%"
     ></script>
     <title>Graasp Builder</title>
   </head>