fix: fix undefined favorite item list (#436)

graasp · Sep 8, 2022 · 6cd4f07 · 6cd4f07
1 parent 25f09c2
commit 6cd4f07
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/cypress/integration/item/favorite/favoriteItem.spec.js b/cypress/integration/item/favorite/favoriteItem.spec.js
@@ -7,6 +7,7 @@ import {
   buildItemMenuButtonId,
   buildItemMenu,
   NAVIGATION_ROOT_ID,
+  FAVORITE_ITEMS_ID,
 } from '../../../../src/config/selectors';
 import {
   buildMemberWithFavorites,
@@ -25,6 +26,19 @@ const toggleFavoriteButton = (itemId) => {
 const favoriteItems = [SAMPLE_ITEMS.items[1].id, SAMPLE_ITEMS.items[2].id];
 
 describe('Favorite Item', () => {
+  describe('Member has no favorite items', () => {
+    beforeEach(() => {
+      cy.setUpApi({
+        ...SAMPLE_ITEMS,
+      });
+      cy.visit(FAVORITE_ITEMS_PATH);
+    });
+
+    it('Show empty table', () => {
+      cy.get(`#${FAVORITE_ITEMS_ID}`).should('exist');
+    });
+  });
+
   describe('Member has several valid favorite items', () => {
     beforeEach(() => {
       cy.setUpApi({

diff --git a/src/utils/member.js b/src/utils/member.js
@@ -1,4 +1,5 @@
 import { validate } from 'uuid';
+import { List } from 'immutable';
 
 export const isMemberIdValid = (memberId) => validate(memberId?.trim());
 
@@ -7,4 +8,4 @@ export const getMemberById = (members, id) =>
 
 export const getMemberAvatar = (extra) => extra?.avatar;
 
-export const getFavoriteItems = (extra) => extra?.favoriteItems;
+export const getFavoriteItems = (extra) => extra?.favoriteItems || List();