Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

fix: validate email with enter #483

Merged
merged 2 commits into from
Oct 24, 2024
Merged

fix: validate email with enter #483

merged 2 commits into from
Oct 24, 2024

Conversation

spaenleh
Copy link
Member

close #475

@spaenleh spaenleh force-pushed the 475-validate-email-with-enter branch 2 times, most recently from 7d8b5d4 to 537c902 Compare October 22, 2024 09:52
@spaenleh spaenleh self-assigned this Oct 22, 2024
@spaenleh spaenleh added the bug Something isn't working label Oct 22, 2024
@spaenleh spaenleh force-pushed the 475-validate-email-with-enter branch from 537c902 to 254b9a2 Compare October 23, 2024 07:21
@spaenleh spaenleh requested review from pyphilia and ReidyT October 23, 2024 07:41
@spaenleh spaenleh force-pushed the 475-validate-email-with-enter branch from 28bfb97 to c814a97 Compare October 23, 2024 08:27
pyphilia
pyphilia suggested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you left an .only!

cypress/e2e/signinWithPassword.cy.ts Outdated Show resolved Hide resolved
src/components/common/Adornments.tsx Show resolved Hide resolved
ReidyT
ReidyT approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐦‍🔥

cypress/e2e/signinWithPassword.cy.ts Outdated Show resolved Hide resolved
@spaenleh spaenleh force-pushed the 475-validate-email-with-enter branch from 021f106 to 4b1b984 Compare October 23, 2024 12:05
@spaenleh spaenleh requested a review from pyphilia October 23, 2024 12:41
@spaenleh spaenleh force-pushed the 475-validate-email-with-enter branch from 4b1b984 to 2c36a10 Compare October 24, 2024 15:13
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.9% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit e671a2a Oct 24, 2024
3 checks passed
@graasper graasper mentioned this pull request Oct 24, 2024
Merged
@sentry-io Sentry.io
Copy link

sentry-io bot commented Oct 27, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NotFoundError: Node.removeChild: The node to be removed is not a child of this node Zj(react-dom/cjs/react-dom.production) View Issue
  • ‼️ NotFoundError: The object can not be found here. insertBefore([native code]) View Issue
  • ‼️ NotFoundError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node. Zj(react-dom/cjs/react-dom.production) View Issue
  • ‼️ NotFoundError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node. Zj(react-dom/cjs/react-dom.production) View Issue

Did you find this useful? React with a 👍 or 👎

@spaenleh spaenleh deleted the 475-validate-email-with-enter branch October 28, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@pyphilia pyphilia pyphilia approved these changes

Assignees

@spaenleh spaenleh

Labels
bug Something isn't working v2.7.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Press Enter on "login with magic link" does not do anything
3 participants
@spaenleh @pyphilia @ReidyT