Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

fix: add changes for mobile register #144

Merged
merged 3 commits into from
Aug 7, 2023
Merged

fix: add changes for mobile register #144

merged 3 commits into from
Aug 7, 2023

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Jul 21, 2023 •
edited
Loading

This PR:

  • handles the registration from mobile in the web auth
  • keeps the parameters passed when using the link to switch from sign-in to sign-up and vice-versa.
  • adds a view that opens when the app is not installed and the universal link is used.
    • need translations
    • need the link to both stores

Screenshot of the /auth screen. It is shown when users followed the deeplink but do not have the app installed.
Capture d’écran 2023-07-21 à 11 55 49

@spaenleh spaenleh linked an issue Jul 21, 2023 that may be closed by this pull request
Apply mobile changes for register #142
Closed
@spaenleh spaenleh requested review from pyphilia and alvrba July 21, 2023 10:05
pyphilia
pyphilia approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

src/components/MobileAuth.tsx Outdated Show resolved Hide resolved
src/components/MobileAuth.tsx Outdated Show resolved Hide resolved
src/components/MobileAuth.tsx Outdated Show resolved Hide resolved
src/components/MobileAuth.tsx Outdated Show resolved Hide resolved
@alvrba
Copy link
Contributor

alvrba commented Jul 21, 2023

I think the links to App Store and Play Store should have the official design (especially from Apple "Download on The App Store"), although I believe it would be no problem if we let the ones from now.

codeofmochi
codeofmochi approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM very nice 👍 @spaenleh do you want me to handle the translations or is it already underway?

package.json Outdated Show resolved Hide resolved
@codeofmochi codeofmochi mentioned this pull request Jul 24, 2023
Closed
@codeofmochi codeofmochi added the feature New feature or request label Jul 24, 2023
@codeofmochi codeofmochi force-pushed the 142-apply-mobile-changes-for-register branch from 6366f99 to 9f1bce6 Compare July 24, 2023 11:08
@spaenleh spaenleh force-pushed the 142-apply-mobile-changes-for-register branch 2 times, most recently from a03145f to 397683b Compare August 2, 2023 09:39
@spaenleh spaenleh force-pushed the 142-apply-mobile-changes-for-register branch from 397683b to eed6a13 Compare August 4, 2023 14:15
@spaenleh spaenleh temporarily deployed to ci August 4, 2023 14:15 — with GitHub Actions Inactive
@spaenleh spaenleh temporarily deployed to development August 4, 2023 14:35 — with GitHub Actions Inactive
@spaenleh
Copy link
Member Author

spaenleh commented Aug 4, 2023

Ref #165. To be added when mobile app is officially released.

@codeofmochi codeofmochi merged commit 812c5c5 into main Aug 7, 2023
@codeofmochi codeofmochi deleted the 142-apply-mobile-changes-for-register branch August 7, 2023 09:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alvrba alvrba alvrba approved these changes

@codeofmochi codeofmochi codeofmochi approved these changes

@pyphilia pyphilia pyphilia approved these changes

Assignees

@codeofmochi codeofmochi

@spaenleh spaenleh

@alvrba alvrba

Labels
feature New feature or request v1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply mobile changes for register
4 participants
@spaenleh @alvrba @pyphilia @codeofmochi