Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visibility attribute to AppData type #69

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Conversation

swouf
Copy link
Contributor

@swouf swouf commented Jan 20, 2023

Additionally, use PermissionLevel from @graasp/sdk

close #68

@swouf swouf added the bug 🪲 Something isn't working label Jan 20, 2023
@swouf swouf requested review from pyphilia and spaenleh January 20, 2023 09:35
@swouf swouf self-assigned this Jan 20, 2023
refactor: use PermissionLevel from @graasp/sdk
@swouf swouf force-pushed the 68-visibility-AppData-type branch from c5a567d to e8930f0 Compare January 20, 2023 10:41
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, I left a comment, see if it makes sens 😀

src/mockServer/mockServer.ts Show resolved Hide resolved
@swouf swouf merged commit f6636d0 into main Jan 23, 2023
@swouf swouf deleted the 68-visibility-AppData-type branch January 23, 2023 16:19
@spaenleh spaenleh added the v0.4.2 visibility, mock api error label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working v0.4.2 visibility, mock api error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add visibility to AppData type
2 participants