Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve keywords in builder to allow to edit #117

Merged
merged 25 commits into from
Mar 1, 2024
Merged

feat: improve keywords in builder to allow to edit #117

merged 25 commits into from
Mar 1, 2024

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Feb 19, 2024 •
edited
Loading

This PR solve #84.
image

@ReidyT ReidyT self-assigned this Feb 19, 2024
@ReidyT ReidyT added the feature New feature or request label Feb 19, 2024
@ReidyT ReidyT requested review from spaenleh and pyphilia February 19, 2024 10:59
ReidyT added 19 commits February 21, 2024 12:18
@ReidyT
feat: implement auto-save feature
fc00c9a
@ReidyT
feat: update hasChanged to consider empty settings
3491d15
@ReidyT
chore(test): remove save button click in enterSettings to test auto save
2dc670d
@ReidyT
fix(test): remove only
514fd11
@ReidyT
feat: first improvements of the keywords in builder
43b0315
@ReidyT
feat: implement global checkbox to select/unselect all
34d0aed
@ReidyT
feat: implement delete row
889b9f6
@ReidyT
feat: add save/cancel all and improve Table responsivity
886d10a
@ReidyT
fix: update onChange in ReadableTextField to avoid erasing edited values
ade3281
@ReidyT
chore: first refactor of the table
0f6d09a
@ReidyT
fix: update saveKeyword compare to not allow to save same keywords
ce31a57
@ReidyT
chore: first refactor of the table
a3a4d51
@ReidyT
fix: update KeyWords component to propagate pendingkeywords to parent
0467659
@ReidyT
chore: continue to refactor
74ec481
@ReidyT
chore(translation): translates the table
00f2348
@ReidyT
fix: update chatbot toggle button to take min space
6c9bbb4
@ReidyT
fix(test): update tests to work correctly with the new table
ae026bd
@ReidyT
chore(test): write E2E tests for the edit keywords table
70a19c4
@ReidyT
fix: disable save buttons when the keyword is empty
3c024fe
@ReidyT ReidyT force-pushed the 84-allow-edit-keywords branch from 3fb1b62 to 3c024fe Compare February 21, 2024 11:33
pyphilia
pyphilia approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, it's big. I would consider a context around your table. So you can have a global storage, and put every logic functions in the context instead of in the middle of the layout. What do you think?

src/utils/keywords.ts Outdated Show resolved Hide resolved
src/components/views/admin/KeywordsTable.tsx Outdated Show resolved Hide resolved
src/components/views/admin/KeywordsTable.tsx Outdated Show resolved Hide resolved
src/components/common/table/ReadableTextField.tsx Outdated Show resolved Hide resolved
@ReidyT ReidyT requested a review from pyphilia February 28, 2024 07:17
spaenleh
spaenleh approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some suggestions !

cypress/e2e/builder/keywords.cy.ts Outdated Show resolved Hide resolved
src/components/common/table/ReadableTextField.tsx Outdated Show resolved Hide resolved
@ReidyT ReidyT merged commit ee6d052 into main Mar 1, 2024
3 checks passed
@ReidyT ReidyT deleted the 84-allow-edit-keywords branch March 1, 2024 08:47
@github-actions github-actions bot mentioned this pull request Feb 21, 2024
Merged
@ReidyT ReidyT linked an issue Mar 1, 2024 that may be closed by this pull request
Allow to edit keywords #84
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees

@ReidyT ReidyT

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to edit keywords
3 participants
@ReidyT @pyphilia @spaenleh